[webkit-reviews] review granted: [Bug 100344] [chromium] remove remaining usages of webkit_support from the TestRunner library : [Attachment 170570] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted jochen at chromium.org's request for
review:
Bug 100344: [chromium] remove remaining usages of webkit_support from the
TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=100344

Attachment 170570: Patch
https://bugs.webkit.org/attachment.cgi?id=170570&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170570&action=review


> Tools/DumpRenderTree/chromium/TestRunner/public/WebEventSender.h:67
> +    enum {
> +	   VKEY_RETURN	 = 0x0D,
> +	   VKEY_PRIOR	 = 0x21,
> +	   VKEY_NEXT	 = 0x22,
> +	   VKEY_END	 = 0x23,
> +	   VKEY_HOME	 = 0x24,
> +	   VKEY_LEFT	 = 0x25,
> +	   VKEY_UP	 = 0x26,
> +	   VKEY_RIGHT	 = 0x27,
> +	   VKEY_DOWN	 = 0x28,
> +	   VKEY_SNAPSHOT = 0x2C,
> +	   VKEY_INSERT	 = 0x2D,
> +	   VKEY_DELETE	 = 0x2E,
> +	   VKEY_APPS	 = 0x5D,
> +	   VKEY_F1	 = 0x70,
> +	   VKEY_LSHIFT	 = 0xA0,
> +	   VKEY_RSHIFT	 = 0xA1,
> +	   VKEY_LCONTROL = 0xA2,
> +	   VKEY_RCONTROL = 0xA3,
> +	   VKEY_LMENU	 = 0xA4,
> +	   VKEY_RMENU	 = 0xA5,
> +    };

Do these need to be declared in the public header rather than in the
implementation somewhere?  I guess you're going to COMPILE_ASSERT them on the
Chromium side or something?