[webkit-reviews] review denied: [Bug 100317] Change PopupMenu positioning on Windows such that behaviour on multiple monitors matches Windows standards. : [Attachment 170533] patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Roger Fong <roger_fong at apple.com>'s
request for review:
Bug 100317: Change PopupMenu positioning on Windows such that behaviour on
multiple monitors matches Windows standards.
https://bugs.webkit.org/show_bug.cgi?id=100317

Attachment 170533: patch
https://bugs.webkit.org/attachment.cgi?id=170533&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170533&action=review


> Source/WebCore/platform/PlatformScreen.h:55
> +    FloatRect monitorFromHwnd(HWND);

This will certainly break all the builds except windows, since HWND is a
windows type.

I'm also not clear on why this should be in platform code, if it is only called
from one place.