[webkit-reviews] review denied: [Bug 100321] Refactor LLInt64 to distinguish the pointer operations from the 64-bit integer operations : [Attachment 170542] Patch - part1: add the <foo>q instructions support to the offline assembler

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Yuqiang Xian
<yuqiang.xian at intel.com>'s request for review:
Bug 100321: Refactor LLInt64 to distinguish the pointer operations from the
64-bit integer operations
https://bugs.webkit.org/show_bug.cgi?id=100321

Attachment 170542: Patch - part1: add the <foo>q instructions support to the
offline assembler
https://bugs.webkit.org/attachment.cgi?id=170542&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=170542&action=review


I think you should fix the X86_INSTRUCTIONS part but otherwise I like where
this is going.

> Source/JavaScriptCore/offlineasm/instructions.rb:216
> +X86_64_INSTRUCTIONS =

The X86_INSTRUCTIONS, and ARMv7_INSTRUCTIONS are used for instructions that are
truly artifacts of that architecture.

The cloop might be built in JSVALUE64 mode on non-X86 64-bit architectures. 
Like, I dunno, PowerPC maybe.  I don't know if anyone does that, but it would
be really weird to name these X86_64_INSTRUCTIONS and then have a PowerPC
64-bit port that uses them.

I suggest putting these instructions into the main instruction list.

> Source/JavaScriptCore/offlineasm/x86.rb:55
> -	   "*#{x86Operand(kind)}"
> +	   "*#{x86Operand(:quad)}"

Is that right?	Shouldn't this be :ptr?