[webkit-reviews] review denied: [Bug 94987] Add webkitHRTimeStamp to DOM events : [Attachment 170536] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Robert Flack <flackr at chromium.org>'s
request for review:
Bug 94987: Add webkitHRTimeStamp to DOM events
https://bugs.webkit.org/show_bug.cgi?id=94987

Attachment 170536: Patch
https://bugs.webkit.org/attachment.cgi?id=170536&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170536&action=review


Also you don't appear to have written any tests.  :(

> Source/WebKit/chromium/ChangeLog:8
> +	   Adds a webkitSystemTime property to DOM events which exposes the
platform event

webkitSystemTime <--- does this need to be updated?

> Source/WebCore/dom/Event.idl:65
> +#if defined(ENABLE_EVENT_SYSTEM_TIME)
> +    readonly attribute double	   systemTime;
> +#endif

Should this be InitializedByEventConstructor ?

Please make this runtime enabled.

You don't need to use #if.  You can use the Conditional attribute.