[webkit-reviews] review granted: [Bug 100313] [V8] DOMData is no longer needed : [Attachment 170524] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 100313: [V8] DOMData is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=100313

Attachment 170524: Patch
https://bugs.webkit.org/attachment.cgi?id=170524&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170524&action=review


LGTM.

> Source/WebCore/bindings/v8/V8DOMMap.cpp:91
> +    DOMDataStore* store = DOMDataStore::from(v8::Isolate::GetCurrent());

This pattern is confusing to me.  It's unclear who owns the object.  Perhaps
sharedInstanceFor?  or lookupForInstance?  or even just changing it back to a
reference makes it clear that the caller isn't responsible for the memory (or
handling null!)