[webkit-reviews] review granted: [Bug 100305] [BlackBerry] Geolocation is segfaulting : [Attachment 170508] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted otcheung at rim.com's request for review:
Bug 100305: [BlackBerry] Geolocation is segfaulting
https://bugs.webkit.org/show_bug.cgi?id=100305

Attachment 170508: Patch
https://bugs.webkit.org/attachment.cgi?id=170508&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=170508&action=review


Some things to fix still before landing.

> Source/WebKit/blackberry/WebCoreSupport/GeolocationClientBlackBerry.cpp:84
> +    return;

Please indent.

> Source/WebKit/blackberry/WebCoreSupport/GeolocationClientBlackBerry.cpp:87
> +    m_pendingPermissionGeolocation = RefPtr<Geolocation>(location);

Maybe you can leave off the RefPtr<Geolocation>.