[webkit-reviews] review granted: [Bug 99716] [Chromium] Add supportMultipleWindows setting for Android : [Attachment 170495] Should now pass on mac bot as well as on chromium

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 99716: [Chromium] Add supportMultipleWindows setting for Android
https://bugs.webkit.org/show_bug.cgi?id=99716

Attachment 170495: Should now pass on mac bot as well as on chromium
https://bugs.webkit.org/attachment.cgi?id=170495&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170495&action=review


> LayoutTests/fast/dom/HTMLAnchorElement/anchor-no-multiple-windows.html:8
> +    testRunner.setCanOpenWindows(true);
> +    testRunner.setPopupBlockingEnabled(false);

Are these redundant?

> Source/WebKit/chromium/tests/WebViewTest.cpp:668
> +TEST_F(WebViewTest, SupportsMultipleWindowsSetting)
> +{
> +    WebView* webView =
FrameTestHelpers::createWebViewAndLoad("about:blank");
> +    webView->settings()->setSupportsMultipleWindows(false);
> +    WebCore::Frame* oldFrame =
static_cast<WebFrameImpl*>(webView->mainFrame())->frame();
> +    WebCore::FrameLoadRequest
request(oldFrame->document()->securityOrigin());
> +    WebCore::WindowFeatures features;
> +    bool created = true;
> +    WebCore::Frame* newFrame = WebCore::createWindow(oldFrame, 0, request,
features, created);
> +    EXPECT_EQ(oldFrame, newFrame);
> +    EXPECT_FALSE(created);
> +}

I would skip this test.  You're reaching too much into WebCore.  The LayoutTest
is much better.