[webkit-reviews] review granted: [Bug 100175] [V8] AbstractWeakReferenceMap is unnecessarily general and complex : [Attachment 170473] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 100175: [V8] AbstractWeakReferenceMap is unnecessarily general and complex
https://bugs.webkit.org/show_bug.cgi?id=100175

Attachment 170473: Patch
https://bugs.webkit.org/attachment.cgi?id=170473&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170473&action=review


This looks great.  Please do the event insanity in a separate patch, and CC
inferno.

> Source/WebCore/bindings/v8/DOMWrapperMap.h:113
> +	   ASSERT(it->value == wrapper);

Release will fail if this isn't ASSERT_UNUSED.