[webkit-reviews] review granted: [Bug 98648] DumpRenderTree should have --pixel-tests option again : [Attachment 167543] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 98648: DumpRenderTree should have --pixel-tests option again
https://bugs.webkit.org/show_bug.cgi?id=98648

Attachment 167543: Patch
https://bugs.webkit.org/attachment.cgi?id=167543&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=167543&action=review


Sorry, this must've fallen off my radar :(.

> Tools/DumpRenderTree/qt/DumpRenderTreeMain.cpp:69
> +// We only support -v, -p, --pixel-tests, --stdout, --stderr and -, all the
others will be

-p doesn't actually work, does it? just --pixel-tests? 

Ideally we'd support -p everywhere as well.