[webkit-reviews] review granted: [Bug 97474] [Chromium] Remove screen-related functions from PlatformSupport : [Attachment 166542] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 97474: [Chromium] Remove screen-related functions from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97474

Attachment 166542: Patch
https://bugs.webkit.org/attachment.cgi?id=166542&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166542&action=review


> Source/WebCore/platform/chromium/PlatformScreenChromium.cpp:92
> +	   return 0;

return false?

> Source/WebCore/platform/chromium/PlatformScreenChromium.cpp:100
> +	   return IntRect();

return FloatRect() ?

> Source/WebCore/platform/chromium/PlatformScreenChromium.cpp:108
> +	   return IntRect();

Return FloatRect() ?

> Source/WebKit/chromium/src/ChromeClientImpl.cpp:910
> +

You've got an extra blank line here.

> Source/WebKit/chromium/src/PlatformSupport.cpp:-369
> -	   return 0;

I see.	This goofiness was here already.  We should still probably clean it up.