[webkit-reviews] review denied: [Bug 100128] [Chromium] Convert Chromium template string to an LDML date format : [Attachment 170333] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 24 13:41:58 PDT 2012


Tony Chang <tony at chromium.org> has denied Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 100128: [Chromium] Convert Chromium template string to an LDML date format
https://bugs.webkit.org/show_bug.cgi?id=100128

Attachment 170333: Patch
https://bugs.webkit.org/attachment.cgi?id=170333&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170333&action=review


> Source/WebKit/chromium/src/LocalizedStrings.cpp:272
> +

Nit: extra blank line?

> Source/WebKit/chromium/src/LocalizedStrings.cpp:281
> +    unsigned literalStart = 0;
> +    unsigned length = templ.length();
> +    for (unsigned i = 0; i < length; ++i) {
> +	   if (templ[i] == '$' && i + 1 < length && (templ[i + 1] == '1' ||
templ[i + 1] == '2')) {
> +	       if (literalStart < i)

As I mentioned on the Chromium side, we should just put ww and yyyy in the
template format. Then we can remove this code.

This probably isn't likely, but is it a problem if "ww" or "yyyy" appears in
the translation?  Do we just match the first occurrence?


More information about the webkit-reviews mailing list