[webkit-reviews] review denied: [Bug 100256] change CMAKE_<CCXX|C>_FLAGS_<RELEASE|DEBUG> from enviroment flags : [Attachment 170448] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Michael Carmody <mcarmody at rim.com>'s
request for review:
Bug 100256: change CMAKE_<CCXX|C>_FLAGS_<RELEASE|DEBUG> from enviroment flags
https://bugs.webkit.org/show_bug.cgi?id=100256

Attachment 170448: Patch
https://bugs.webkit.org/attachment.cgi?id=170448&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=170448&action=review


I agree this is useful! Please fix the minor issues.

> Source/cmake/OptionsBlackBerry.cmake:129
> +	   message( "<<<< ENV Overide RELEASE ${CMAKE_CXX_FLAGS_RELEASE}" )

Better use == instead of <<<< to match our style elsewhere. Also it is
override.

> Source/cmake/OptionsBlackBerry.cmake:134
> +	   message( "<<<< ENV Overide DEBUG ${CMAKE_CXX_FLAGS_DEBUG}")

Ditto.