[webkit-reviews] review denied: [Bug 73865] V8 wrappers for TextTrack and TextTrackCue should not be collected on event dispatch and when parent/owner are still reachable : [Attachment 170454] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Aaron Colwell
<acolwell at chromium.org>'s request for review:
Bug 73865: V8 wrappers for TextTrack and TextTrackCue should not be collected
on event dispatch and when parent/owner are still reachable
https://bugs.webkit.org/show_bug.cgi?id=73865

Attachment 170454: Patch
https://bugs.webkit.org/attachment.cgi?id=170454&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170454&action=review


> Source/WebCore/html/track/TextTrackCue.cpp:235
> +    suspendIfNeeded();

We usually call this function in create().  Take a look at how the other
subclasses of ActiveDOMObject handle this issue.

> Source/WebCore/html/track/TextTrackCue.cpp:1063
> +    return m_track;

Are we sure that m_track will become false at some point?  Otherwise we'll
leak.