[webkit-reviews] review granted: [Bug 99925] Setting width of a flexitem causes the adjacent flex item to be displayed poorly. : [Attachment 170431] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 99925: Setting width of a flexitem causes the adjacent flex item to be
displayed poorly.
https://bugs.webkit.org/show_bug.cgi?id=99925

Attachment 170431: Patch
https://bugs.webkit.org/attachment.cgi?id=170431&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170431&action=review


> Source/WebCore/rendering/RenderFlexibleBox.cpp:672
> +    // If the child moved, we have to repaint it as well as any
floating/positioned
> +    // descendants. An exception is if we need a layout. In this case, we
know we're going to

Maybe add a FIXME that we sometimes overpaint in cases where we flip positions
(e.g. for rtl column)?