[webkit-reviews] review granted: [Bug 100224] [Qt] Detach WebContext's clients from QtWebContext : [Attachment 170363] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Jocelyn Turcotte
<jocelyn.turcotte at digia.com>'s request for review:
Bug 100224: [Qt] Detach WebContext's clients from QtWebContext
https://bugs.webkit.org/show_bug.cgi?id=100224

Attachment 170363: Patch
https://bugs.webkit.org/attachment.cgi?id=170363&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170363&action=review


> Source/WebKit2/UIProcess/API/qt/qwebiconimageprovider.cpp:53
> +    url.setPath(QLatin1Char('/') +
QString::number(WTF::StringHash::hash(iconURL)));

I have the guts feeling that we might change the format of this in the future,
perhaps re-introduce a context id?

This makes me wonder if we should introduce a version in the URL, like versions
in REST APIs.