[webkit-reviews] review granted: [Bug 100205] Fix CALayer hiearchy when combining tiling with preserve-3d : [Attachment 170326] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 100205: Fix CALayer hiearchy when combining tiling with preserve-3d
https://bugs.webkit.org/show_bug.cgi?id=100205

Attachment 170326: Patch
https://bugs.webkit.org/attachment.cgi?id=170326&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=170326&action=review


> Source/WebCore/ChangeLog:25
> +	   Test: compositing/tiling/backface-preserve-3d-tiled.html

Does the chrome failure just get baselined at some later stage?

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1192
> +    PlatformCALayerList& childListForSublayers = m_structuralLayer ?
structuralLayerChildren : primaryLayerChildren;

It might be a bit clearer if you move this line down to in front of the loop
where you actually use it, but not a strong opinion.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1205
> +    if (m_contentsLayer && m_contentsVisible)
> +	   primaryLayerChildren.append(m_contentsLayer);

Does the FIXME you removed still apply?