[webkit-reviews] review denied: [Bug 100237] IconDatabase: Properly clean up on destruction : [Attachment 170427] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 24 10:55:35 PDT 2012
Brady Eidson <beidson at apple.com> has denied Jocelyn Turcotte
<jocelyn.turcotte at digia.com>'s request for review:
Bug 100237: IconDatabase: Properly clean up on destruction
https://bugs.webkit.org/show_bug.cgi?id=100237
Attachment 170427: Patch
https://bugs.webkit.org/attachment.cgi?id=170427&action=review
------- Additional Comments from Brady Eidson <beidson at apple.com>
You should only explicitly call ::close() on the WebCore::IconDatabase. You
should not actually cause it to be destroyed.
We don't run destructors at exit time.
More information about the webkit-reviews
mailing list