[webkit-reviews] review denied: [Bug 100145] [BlackBerry] Extending existing ThreadUnsafe singletons in webkit to Generic ThreadUnsafe Singleton : [Attachment 170391] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Parth Patel <parpatel at rim.com>'s
request for review:
Bug 100145: [BlackBerry] Extending existing ThreadUnsafe singletons in webkit
to Generic ThreadUnsafe Singleton
https://bugs.webkit.org/show_bug.cgi?id=100145

Attachment 170391: Patch
https://bugs.webkit.org/attachment.cgi?id=170391&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=170391&action=review


Please fix the Changelogs.

> Source/WebCore/ChangeLog:7
> +	   Reviewed by: Yong Li.

This is ot how we do it. It is better to keep the original Reviewed by
(OOPS)!!! line here. What you should do is an extra line with "Reviewed
internally by XXX". Have a look at our other commits.

> Source/WebCore/ChangeLog:12
> +	   https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=214384

You can just abbreviate to PR214384.

> Source/WebKit/blackberry/ChangeLog:7
> +	   Reviewed by: Yong Li.

Ditto.

> Source/WebKit/blackberry/ChangeLog:12
> +	   https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=214384

Ditto.