[webkit-reviews] review denied: [Bug 96602] -ldl should not be hardcoded into OPENGL_LIBS : [Attachment 170343] proposed patch, v3

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has denied Alexandre Rostovtsev
<tetromino at gentoo.org>'s request for review:
Bug 96602: -ldl should not be hardcoded into OPENGL_LIBS
https://bugs.webkit.org/show_bug.cgi?id=96602

Attachment 170343: proposed patch, v3
https://bugs.webkit.org/attachment.cgi?id=170343&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=170343&action=review


> configure.ac:282
> +AC_SUBST([DLOPEN_LIBS])

This makes sense, but would you mind adding a small comment saying what it
does? Mostly because it's checking for the uncommon case (BSD-ish systems), so
it's possible that a maintainer will be confused in the future. Something like:


"We check whether dlopen is in the core libraries; if it's not we pull in libdl
if it has dlopen and is available, as it's needed in GNU/Linux."

Thanks!