[webkit-reviews] review granted: [Bug 93611] WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled' : [Attachment 169398] disable continuous spell checker for Mac and rebase the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 24 01:42:47 PDT 2012


Hajime Morrita <morrita at google.com> has granted Grzegorz Czajkowski
<g.czajkowski at samsung.com>'s request for review:
Bug 93611: WebKitTestRunner needs to turn on
'setContinuousSpellCheckingEnabled'
https://bugs.webkit.org/show_bug.cgi?id=93611

Attachment 169398: disable continuous spell checker for Mac and rebase the
patch
https://bugs.webkit.org/attachment.cgi?id=169398&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=169398&action=review


Looks sane. rs=me.

> LayoutTests/ChangeLog:3
> +	   WebKitTestRunner needs to turn on
'setContinuousSpellCheckingEnabled'

Could you make it clear that this change is for EFL port by, for example,
tagging with [EFF]?

> Source/WebKit2/ChangeLog:3
> +	   WebKitTestRunner needs to turn on
'setContinuousSpellCheckingEnabled'

Ditto.


More information about the webkit-reviews mailing list