[webkit-reviews] review granted: [Bug 100180] Stop using NSHomeDirectory() to get the home directory, it doesn't always return what we want : [Attachment 170293] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 100180: Stop using NSHomeDirectory() to get the home directory, it doesn't
always return what we want
https://bugs.webkit.org/show_bug.cgi?id=100180

Attachment 170293: Patch
https://bugs.webkit.org/attachment.cgi?id=170293&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=170293&action=review


> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:214
> +    int bufferSize = 4096;
> +    char buffer[4096];

Please write this as

char buffer[4096];
int bufferSize = sizeof(buffer);