[webkit-reviews] review granted: [Bug 99836] [GTK] Add API to get the WebKitWebView associated to a WebKitDownload to WebKit2 GTK+ : [Attachment 169614] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 99836: [GTK] Add API to get the WebKitWebView associated to a
WebKitDownload to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=99836

Attachment 169614: Patch
https://bugs.webkit.org/attachment.cgi?id=169614&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169614&action=review


> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:295
> + * start a download from a particular #WebKitWebView use

Nit: start -> starting

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:993
> +void webkitWebViewBaseSetDownloadRequestHandler(WebKitWebViewBase*
webViewBase, WebKitWebViewBaseDownloadRequestHandler downloadHandler)
> +{
> +    webViewBase->priv->downloadHandler = downloadHandler;
> +}
> +
> +void webkitWebViewBaseHandleDownloadRequest(WebKitWebViewBase* webViewBase,
DownloadProxy* download)
> +{
> +    if (webViewBase->priv->downloadHandler)
> +	   webViewBase->priv->downloadHandler(webViewBase, download);
> +}

I guess this is to avoid exposing any API in the base class. I think we should
think seriously about just getting rid of WebKitWebViewBase before the stable
release.