[webkit-reviews] review granted: [Bug 99899] Turn PageLoad tests into simple performancetests : [Attachment 170269] light version of the proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 23 17:13:50 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Zoltan Horvath
<zoltan at webkit.org>'s request for review:
Bug 99899: Turn PageLoad tests into simple performancetests
https://bugs.webkit.org/show_bug.cgi?id=99899

Attachment 170269: light version of the proposed patch
https://bugs.webkit.org/attachment.cgi?id=170269&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170269&action=review


> PerformanceTests/resources/runner.js:344
> -	   this.file = PerfTestRunner.loadFile(test.path);
> +	   test.file = PerfTestRunner.loadFile(test.path);

We should probably store this as a local variable instead of attaching it to
the test object.


More information about the webkit-reviews mailing list