[webkit-reviews] review granted: [Bug 100169] We should make TileCache tiles the size of the tile coverage rect when we can't do fast scrolling : [Attachment 170267] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 100169: We should make TileCache tiles the size of the tile coverage rect
when we can't do fast scrolling
https://bugs.webkit.org/show_bug.cgi?id=100169

Attachment 170267: Patch
https://bugs.webkit.org/attachment.cgi?id=170267&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=170267&action=review


> Source/WebCore/platform/graphics/ca/mac/TileCache.mm:49
> +static const int defaultTileCacheWidth = 512;
> +static const int defaultTileCacheHeight = 512;

Normally it would be good to include a comment stating why this is the default.


> Source/WebCore/platform/graphics/ca/mac/TileCache.mm:59
> +    , m_tileSize(IntSize(defaultTileCacheWidth, defaultTileCacheHeight))

I think you can leave out IntSize() here since it’s already the initializer
list for an IntSize.