[webkit-reviews] review denied: [Bug 99694] Refactor SVGAnimationElement's calcMode() and animationMode() for performance : [Attachment 169775] First pass

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Philip Rogers <pdr at google.com>'s
request for review:
Bug 99694: Refactor SVGAnimationElement's calcMode() and animationMode() for
performance
https://bugs.webkit.org/show_bug.cgi?id=99694

Attachment 169775: First pass
https://bugs.webkit.org/attachment.cgi?id=169775&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169775&action=review


pdr says he'll split this up. :)

> Source/WebCore/svg/SVGAnimateMotionElement.cpp:49
> +    m_calcMode = CalcModePaced;

setCalcMode()?

> Source/WebCore/svg/SVGAnimateMotionElement.cpp:115
>	   m_path = Path();
>	   buildPathFromString(attribute.value(), m_path);
> +	   updateAnimationPath();

What about calling this from a setPath() (or setPathFromString?) method?