[webkit-reviews] review granted: [Bug 100162] [WebKit2 API] Add a method to get textRects from a WKDOMRange or WKDOMNode : [Attachment 170246] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Andy Estes <aestes at apple.com>'s request
for review:
Bug 100162: [WebKit2 API] Add a method to get textRects from a WKDOMRange or
WKDOMNode
https://bugs.webkit.org/show_bug.cgi?id=100162

Attachment 170246: Patch
https://bugs.webkit.org/attachment.cgi?id=170246&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170246&action=review


> Source/WebCore/dom/Range.cpp:1626
> +void Range::textRectsAfterUpdatingLayout(Vector<IntRect>& rects, bool
useSelectionHeight, RangeInFixedPosition* inFixed) const
> +{
> +    ownerDocument()->updateLayoutIgnorePendingStylesheets();
> +    textRects(rects, useSelectionHeight, inFixed);
> +}

I would remove this and just call updateLayoutIgnorePendingStylesheets() where
needed.

> Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMRange.h:43
> +- (NSArray *)textRects;

How about a property?