[webkit-reviews] review granted: [Bug 93146] Coordinated Graphics: Enable threaded/IPC animations : [Attachment 169716] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 23 14:45:59 PDT 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 93146: Coordinated Graphics: Enable threaded/IPC animations
https://bugs.webkit.org/show_bug.cgi?id=93146

Attachment 169716: Patch
https://bugs.webkit.org/attachment.cgi?id=169716&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169716&action=review


> Source/WebCore/platform/graphics/GraphicsLayerAnimation.h:48
> +    void setState(AnimationState s, double pauseTime = 0)

pauseTime? when to pause?

> Source/WebCore/platform/graphics/GraphicsLayerAnimation.h:61
> +    bool listsMatch() const { return m_listsMatch; }

I dont understand what this represents


More information about the webkit-reviews mailing list