[webkit-reviews] review granted: [Bug 100144] In the open-source jpeg decoder, read image orientation from the exif data : [Attachment 170219] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Nico Weber <thakis at chromium.org>'s
request for review:
Bug 100144: In the open-source jpeg decoder, read image orientation from the
exif data
https://bugs.webkit.org/show_bug.cgi?id=100144

Attachment 170219: Patch
https://bugs.webkit.org/attachment.cgi?id=170219&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170219&action=review


This is definitely more readable to my eyes.  Thank you. Helps that I read it
twice, I'm sure. :)

> Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:166
> +	   // data[5] is a fill byte

What's a fill byte?

> Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:188
> +	   ifdOffset += 6; // Account for 'Exif\0\0' header.

Why Exif\0\0 here and only Exif\0 above?