[webkit-reviews] review granted: [Bug 99947] Handle two-finger tap gestures in the same way as long-press gestures : [Attachment 169821] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Terry Anderson
<tdanderson at chromium.org>'s request for review:
Bug 99947: Handle two-finger tap gestures in the same way as long-press
gestures
https://bugs.webkit.org/show_bug.cgi?id=99947

Attachment 169821: Patch
https://bugs.webkit.org/attachment.cgi?id=169821&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169821&action=review


>> Source/WebCore/page/EventHandler.cpp:2526
>>	    return handleGestureLongPress(gestureEvent);
> 
> Is this OK or should I instead have a handleGestureLongPress() and a
handleGestureTwoFingerTap() which both call a common function containing the
current implementation of handleGestureLongPress() ?

Its probably clearer to do that.  This code really just wants to dispatch based
on the type without making any policy decisions about what the gestures mean.