[webkit-reviews] review granted: [Bug 74802] Add timeout support to XMLHttpRequest : [Attachment 170075] Patch v6, ChangeLog clarification.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 23 10:25:03 PDT 2012


Nate Chapin <japhet at chromium.org> has granted Dominik Röttsches (drott)
<dominik.rottsches at intel.com>'s request for review:
Bug 74802: Add timeout support to XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=74802

Attachment 170075: Patch v6, ChangeLog clarification.
https://bugs.webkit.org/attachment.cgi?id=170075&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170075&action=review


> LayoutTests/ChangeLog:13
> +	   I adapted them for W3C testharness.js and split them into groups
with shorter test running time
> +	   so that they can be used as WebKit layout tests. Each individual
test should
> +	   complete in less than 20 seconds.

I assume the timeout durations are the same as the mozilla version of these
tests?

It's still unfortunate that the tests run quite so long, but I suppose it is
necessary to given what's being tested.


More information about the webkit-reviews mailing list