[webkit-reviews] review denied: [Bug 99975] Remove ensureAuxiliaryContext : [Attachment 170081] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Dan Carney <dcarney at google.com>'s
request for review:
Bug 99975: Remove ensureAuxiliaryContext
https://bugs.webkit.org/show_bug.cgi?id=99975

Attachment 170081: Patch
https://bugs.webkit.org/attachment.cgi?id=170081&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170081&action=review


> Source/WebCore/bindings/v8/V8Binding.cpp:322
> +	       if (worldToUse == UseCurrentWorld) {
> +		   if (V8DOMWindowShell* isolatedContext =
V8DOMWindowShell::getEntered())
> +		       return
v8::Local<v8::Context>::New(isolatedContext->context());
> +	       }
> +	       return frame->script()->mainWorldContext();

This seems wrong.  If we pass UseCurrentWorld but we're not in a V8 context,
then we'll return the main world's context.  Perhaps this function should crash
if we're not in a context?

The underlying problem is that the operation this function is trying to perform
is impossible.	It's not possible to convert a ScriptExecutionContext to a
v8::Context because there is a one-to-many relationship between
ScriptExecutionContext and v8::Context.