[webkit-reviews] review granted: [Bug 98024] Web Inspector: Implement CSS reload upon related SASS resource saving : [Attachment 170093] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 98024: Web Inspector: Implement CSS reload upon related SASS resource
saving
https://bugs.webkit.org/show_bug.cgi?id=98024

Attachment 170093: Patch
https://bugs.webkit.org/attachment.cgi?id=170093&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170093&action=review


> Source/WebCore/inspector/front-end/SASSSourceMapping.js:76
> +	   var timer = this._timeoutForURL[sassURL];

I would reuse timeout :)

> Source/WebCore/inspector/front-end/Settings.js:108
> +    this.cssReloadTimeout = this.createSetting("cssReloadTimeout", 1000);

I don't think this should be enabled by default.

> Source/WebCore/inspector/front-end/SettingsScreen.js:312
> +	   setting.className = "setting";

number-setting?

> Source/WebCore/inspector/front-end/helpScreen.css:214
> +.help-content p.setting {

Looks like we generally use fieldset for that.