[webkit-reviews] review granted: [Bug 99552] The order of resolving distribution in tree composition is wrong : [Attachment 170070] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 99552: The order of resolving distribution in tree composition is wrong
https://bugs.webkit.org/show_bug.cgi?id=99552

Attachment 170070: Patch
https://bugs.webkit.org/attachment.cgi?id=170070&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170070&action=review


> Source/WebCore/html/shadow/ContentDistributor.cpp:107
> +	   if (ElementShadow* shadow =
firstActiveShadowInsertionPointInOldestShadowRoot->parentNode()->isElementNode(
) ?
toElement(firstActiveShadowInsertionPointInOldestShadowRoot->parentNode())->sha
dow() : 0)

I think you can turn this into a helper function -- you use it twice in this
code, and it might be good to have a nice name explaining the purpose.