[webkit-reviews] review requested: [Bug 100093] [EFL][WK2] Make request manager client a C++ class : [Attachment 170138] Patch

[bugzilla-daemon at webkit.org]

Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com> has asked  for review:
Bug 100093: [EFL][WK2] Make request manager client a C++ class
https://bugs.webkit.org/show_bug.cgi?id=100093

Attachment 170138: Patch
https://bugs.webkit.org/attachment.cgi?id=170138&action=review

------- Additional Comments from Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=170138&action=review


> Source/WebKit2/UIProcess/efl/RequestManagerClientEfl.cpp:72
> +{

maybe ASSERT(m_context) ?

> Source/WebKit2/UIProcess/efl/RequestManagerClientEfl.h:29
> +#include "ewk_context_private.h"

class Ewk_Context; ?

> Source/WebKit2/UIProcess/efl/RequestManagerClientEfl.h:50
> +    Ewk_Url_Scheme_Handler schemeHandler(const String& scheme) const;

do you really need this method?

> Source/WebKit2/UIProcess/efl/RequestManagerClientEfl.h:56
> +    typedef HashMap<String, Ewk_Url_Scheme_Handler> URLSchemeHandlerMap;

typedef HashMap<String, class Ewk_Url_Scheme_Handler> ?