[webkit-reviews] review granted: [Bug 99259] Web Inspector: Sass can only resolve same folder paths : [Attachment 170076] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 23 02:18:35 PDT 2012


Vsevolod Vlasov <vsevik at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 99259: Web Inspector: Sass can only resolve same folder paths
https://bugs.webkit.org/show_bug.cgi?id=99259

Attachment 170076: Patch
https://bugs.webkit.org/attachment.cgi?id=170076&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=170076&action=review


> Source/WebCore/inspector/front-end/CSSStyleModel.js:516
> +	   if (!this._locations)

Redundant.

> Source/WebCore/inspector/front-end/CSSStyleModel.js:823
> +WebInspector.CSSRule.Location = function(rawLocation, updateDelegate)

Where is nothing rule specific here, let's call it
WebInspector.CSSStyleModel.Location instead?


More information about the webkit-reviews mailing list