[webkit-reviews] review denied: [Bug 99259] Web Inspector: Sass can only resolve same folder paths : [Attachment 169889] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 99259: Web Inspector: Sass can only resolve same folder paths
https://bugs.webkit.org/show_bug.cgi?id=99259

Attachment 169889: Patch
https://bugs.webkit.org/attachment.cgi?id=169889&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169889&action=review


> Source/WebCore/inspector/front-end/CSSStyleModel.js:505
> +	   if (!location.uiLocation())

Does it ever happen? We should avoid having rawLocation that does not have
matching uiLocation as much as possible.

> Source/WebCore/inspector/front-end/CSSStyleModel.js:508
> +	       this._locations = [];

nit: We will always have some live locations on CSSStyleModel, so I would move
this._locations = []; to constructor (and annotate it) to make code simpler.

> Source/WebCore/inspector/front-end/Linkifier.js:113
> +    _updateCSSAnchor: function(anchor, uiLocation)

You should reuse _updateAnchor and move CSS domain specific logic to you own
LinkifierFormatter implementation (probably inherited form DefaultFormatter).