[webkit-reviews] review granted: [Bug 99980] Web Inspector: Elaborate source panel sidebar context menus. : [Attachment 169879] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 22 22:21:28 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has granted eustas.bug at gmail.com's
request for review:
Bug 99980: Web Inspector: Elaborate source panel sidebar context menus.
https://bugs.webkit.org/show_bug.cgi?id=99980

Attachment 169879: Patch
https://bugs.webkit.org/attachment.cgi?id=169879&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169879&action=review


> Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js:198
> +	       var breakpointActiveTitle =
WebInspector.UIString(breakpointActive ? "Deactivate All Breakpoints" :
"Activate All Breakpoints");

We can change state of "Activate All Breakpoints" option on the toolbar even if
there are no breakpoints so I think it could make sense to always have this
option in the context menu no matter how many breakpoints we have.


More information about the webkit-reviews mailing list