[webkit-reviews] review denied: [Bug 99703] [chromium] Add additional memory management fields to WebGraphicsContext3D : [Attachment 169383] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 22 18:49:46 PDT 2012


James Robinson <jamesr at chromium.org> has denied Christopher Cameron
<ccameron at chromium.org>'s request for review:
Bug 99703: [chromium] Add additional memory management fields to
WebGraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=99703

Attachment 169383: Patch
https://bugs.webkit.org/attachment.cgi?id=169383&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169383&action=review


I really dislike adding things "just in case".	Let's figure out what we
actually need and do that.  If we don't know whether we need something yet, we
definitely do not.

> Source/Platform/chromium/public/WebGraphicsMemoryAllocation.h:92
> +struct WebGraphicsManagedMemoryStats {

WebKit API requires one header per type. see
http://trac.webkit.org/wiki/ChromiumWebKitAPI


More information about the webkit-reviews mailing list