[webkit-reviews] review granted: [Bug 100044] [Mac] Remove extraneous conversion to String->NSString : [Attachment 170029] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 22 18:25:31 PDT 2012
Darin Adler <darin at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 100044: [Mac] Remove extraneous conversion to String->NSString
https://bugs.webkit.org/show_bug.cgi?id=100044
Attachment 170029: Patch
https://bugs.webkit.org/attachment.cgi?id=170029&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=170029&action=review
> Source/WebCore/loader/mac/LoaderNSURLExtras.mm:75
> + if ((mimeType == "application/tar" || mimeType == "application/x-tar")
Why is it OK for us to check something case insensitive (a MIME type) with a
case sensitive comparison?
More information about the webkit-reviews
mailing list