[webkit-reviews] review denied: [Bug 100029] Add measurePageLoadTime function to PerfTestRunner : [Attachment 169997] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 22 15:41:12 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has denied Zoltan Horvath <zoltan at webkit.org>'s
request for review:
Bug 100029: Add measurePageLoadTime function to PerfTestRunner
https://bugs.webkit.org/show_bug.cgi?id=100029

Attachment 169997: Patch
https://bugs.webkit.org/attachment.cgi?id=169997&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169997&action=review


>> PerformanceTests/resources/runner.js:343
>> +			iframe.contentDocument.documentElement.offsetWidth; //
Force the painting.
> 
> This is not going to work since a HTML document without a body element will
still have the document element. You need to check whether the document is a
HTML document or not, and if it is, then don't force paint until we find body.

In fact, r- because of this.


More information about the webkit-reviews mailing list