[webkit-reviews] review denied: [Bug 99750] [Shadow]: Fallback content should also be reprojected : [Attachment 169869] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 99750: [Shadow]: Fallback content should also be reprojected
https://bugs.webkit.org/show_bug.cgi?id=99750

Attachment 169869: Patch
https://bugs.webkit.org/attachment.cgi?id=169869&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169869&action=review


> Source/WebCore/html/shadow/HTMLContentElement.h:65
> +inline HTMLContentElement* toHTMLContentElement(Node* node)

Is this used anywhere?

> Source/WebCore/html/shadow/InsertionPoint.h:123
> +inline Node* parentNodeForDistribution(const Node* node)

Why is this hanging in the InsertionPoint? And why are the two methods? Can't
this just be an inline static helper inside of the ComposedShadowTreeWalker? It
seems like you are prematurely building an API when there's only one consumer
of this function.