[webkit-reviews] review granted: [Bug 100033] [V8] Enumerate Nodes via the V8 heap rather than via a list in WebCore : [Attachment 169989] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 100033: [V8] Enumerate Nodes via the V8 heap rather than via a list in
WebCore
https://bugs.webkit.org/show_bug.cgi?id=100033

Attachment 169989: Patch
https://bugs.webkit.org/attachment.cgi?id=169989&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169989&action=review


LGTM.  You may wish to have Kentaro look too, as he's undoubtably more versed
in this than I.

> Source/WebCore/bindings/v8/V8DOMMap.cpp:119
> +	       v8::Persistent<v8::Object> wrapper =
v8::Persistent<v8::Object>::Cast(value);

I assume this ASSERTs, etc. that this is an Object?