[webkit-reviews] review granted: [Bug 99982] [EFL][WK2] Make the resource load client a C++ class : [Attachment 169929] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 99982: [EFL][WK2] Make the resource load client a C++ class
https://bugs.webkit.org/show_bug.cgi?id=99982

Attachment 169929: Patch
https://bugs.webkit.org/attachment.cgi?id=169929&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169929&action=review


r=me

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:839
> +    priv->resourceLoadClient = ResourceLoadClientEfl::create(ewkView);

why not call it ResourceLoaderClientEfl to show the relation to
FrameLoaderClient

> Source/WebKit2/UIProcess/efl/ResourceLoadClientEfl.cpp:131
> +    WKPageResourceLoadClient wkResourceLoadClient;

Ah I see now...