[webkit-reviews] review granted: [Bug 99985] [GTK] Don't use deprecated AccessibilityObject methods after r99502 : [Attachment 169888] Patch proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 22 09:08:02 PDT 2012


chris fleizach <cfleizach at apple.com> has granted Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 99985: [GTK] Don't use deprecated AccessibilityObject methods after r99502
https://bugs.webkit.org/show_bug.cgi?id=99985

Attachment 169888: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=169888&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=169888&action=review


just one inline question...
I think changes look good for the first pass to ensure compatibility. Going
forward GTK will probably want to adapt to provide better behavior and a way to
expose aria-help, aria-describedby, summary and a few other types of text

> Source/WebCore/accessibility/gtk/WebKitAccessibleUtil.cpp:102
> +	   return String();

this snippet is a Mac concept. Just want to make sure it also applies to GTK


More information about the webkit-reviews mailing list