[webkit-reviews] review denied: [Bug 99994] [Qt] Use the DNS resolve queue : [Attachment 169903] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 22 07:19:22 PDT 2012


Simon Hausmann <hausmann at webkit.org> has denied Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 99994: [Qt] Use the DNS resolve queue
https://bugs.webkit.org/show_bug.cgi?id=99994

Attachment 169903: Patch
https://bugs.webkit.org/attachment.cgi?id=169903&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=169903&action=review


>> Source/WebCore/platform/network/qt/DnsPrefetchHelper.h:22
>> +#include "config.h"
> 
> Header file should not contain WebCore config.h. Should be: alphabetically
sorted.  [build/include_order] [4]

I think the style queue is right here and so I think this requires the code to
be moved into DnsPrefetchHelper.cpp. I wonder why it's inline anyway :)

Otherwise the change looks good!


More information about the webkit-reviews mailing list