[webkit-reviews] review granted: [Bug 99815] [Shadow] ASSERT triggered when we try reprojecting fallback elements : [Attachment 169840] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 99815: [Shadow] ASSERT triggered when we try reprojecting fallback elements
https://bugs.webkit.org/show_bug.cgi?id=99815

Attachment 169840: Patch
https://bugs.webkit.org/attachment.cgi?id=169840&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=169840&action=review


> Source/WebCore/ChangeLog:12
> +	   We have confirmed that this patch does not regress the performance
so much. The summary of the

Don't need "so much". This obviously has no perf impact. Be confident :-)

> Source/WebCore/dom/ContainerNode.h:NaN
>  inline void ContainerNode::attachChildren()

Do we have attachChildren() anywhere else? I believe we can replace
attachChildren() with the "IfNeeed" version.