[webkit-reviews] review granted: [Bug 66173] [Qt] Add eventSender.gestureTap : [Attachment 165132] Patch2

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 66173: [Qt] Add eventSender.gestureTap
https://bugs.webkit.org/show_bug.cgi?id=66173

Attachment 165132: Patch2
https://bugs.webkit.org/attachment.cgi?id=165132&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165132&action=review


r=me but needs #include order fix before landing I suppose :)

> Source/WebKit/qt/WebCoreSupport/WebEventConversion.cpp:322
> +	   m_position = event->widget()->mapFromGlobal(globalPos.toPoint());

With the upcoming QtWebKit <> QtWebKitWidgets split in mind it would be great
if the widget local position could be provided as a parameter from outside to
reduce the amount of widget code here :)