[webkit-reviews] review denied: [Bug 98031] [Qt] QNX build fails due to disabled LLInt : [Attachment 166483] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Milian Wolff
<milian.wolff at kdab.com>'s request for review:
Bug 98031: [Qt] QNX build fails due to disabled LLInt
https://bugs.webkit.org/show_bug.cgi?id=98031

Attachment 166483: Patch
https://bugs.webkit.org/attachment.cgi?id=166483&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166483&action=review


> Source/JavaScriptCore/DerivedSources.pri:87
> -linux-*:!equals(QT_ARCH, "arm") {
> +!equals(QT_ARCH, "arm"):linux-*|qnx {

I think the safest way to write this is to use if():

    linux-*:!equals(QT_ARCH, "arm")

becomes

    if(linux-*|qnx):!equals(QT_ARCH, "arm")

Then it's unambigious to qmake as well as to the reader :)

Similar in the other cases below.