[webkit-reviews] review granted: [Bug 98040] [Qt] QNX build fails when building against Qt without clipboard support : [Attachment 166490] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 21 23:16:32 PDT 2012


Simon Hausmann <hausmann at webkit.org> has granted Milian Wolff
<milian.wolff at kdab.com>'s request for review:
Bug 98040: [Qt] QNX build fails when building against Qt without clipboard
support
https://bugs.webkit.org/show_bug.cgi?id=98040

Attachment 166490: Patch
https://bugs.webkit.org/attachment.cgi?id=166490&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166490&action=review


> Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp:487
> +#if PLATFORM(QT) && !defined(QT_NO_CLIPBOARD)

This is a bit risky for new else clause changes, but ok.


More information about the webkit-reviews mailing list