[webkit-reviews] review granted: [Bug 88606] [Shadow DOM] Needs @host rule for ShadowDOM styling : [Attachment 169594] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has granted Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 88606: [Shadow DOM] Needs @host rule for ShadowDOM styling
https://bugs.webkit.org/show_bug.cgi?id=88606

Attachment 169594: Patch
https://bugs.webkit.org/attachment.cgi?id=169594&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=169594&action=review


Almost looks good. Added some nits comment.

> Source/WebCore/css/CSSGrammar.y.in:907
> +before_host_rule:

We need to #ifdef these.

> Source/WebCore/css/CSSParser.cpp:9188
> +    case 'h':

Ditto.

> Source/WebCore/css/RuleSet.h:34
> +enum AddRuleState {

Nit: This isn't actually a state. Maybe flags?

> Source/WebCore/css/StyleResolver.h:178
> +    {

Could you assert RuntimeEnabledFeatures::shadowDOMEnabled() ||
styleScoepedEnabled() here to emphasize this is only enabled with these
features being on?

> Source/WebCore/css/StyleScopeResolver.cpp:203
> +    // FIXME(99827): add a new flag to ElementShadow and cache whether any

Could you type the url instead of bug number?

> Source/WebCore/css/StyleScopeResolver.cpp:225
> +    // FIXME(99827): add a new flag to ElementShadow and cache whether any

Ditto.